Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor around TxEip4844Variant #738

Merged
merged 1 commit into from
May 13, 2024
Merged

refactor around TxEip4844Variant #738

merged 1 commit into from
May 13, 2024

Conversation

tcoratger
Copy link
Contributor

Summary of the refactors made:

  • Use Self instead of TxEip4844Variant where possible
  • Use From implementation where possible

@DaniPopes DaniPopes merged commit 6fe26e2 into alloy-rs:main May 13, 2024
24 checks passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@tcoratger
refactor around TxEip4844Variant (alloy-rs#738)
5baf224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcoratger @prestwich @DaniPopes